Feature expr2c extension #2599
Feature expr2c extension #2599
Conversation
There was a problem hiding this comment.
Passed Diffblue compatibility checks (cbmc commit: 659aa44).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/80160965
| @@ -1998,14 +1918,12 @@ std::string expr2ct::convert_constant_bool(bool boolean_value) | |||
| { | |||
| // C doesn't really have these | |||
| if(boolean_value) | |||
| return "TRUE"; | |||
| return "1"; | |||
There was a problem hiding this comment.
Changing the boolean value was the original reason for this commit.
I am sorry for the reformatting around this change in the commit.
My intend was to change TRUE to 1 and FALSE to 0.
mmuesly
force-pushed
the
feature_expr2c_extension
branch
from
659aa44 to
131bb8c
Compare
There was a problem hiding this comment.
This PR failed Diffblue compatibility checks (cbmc commit: 131bb8c).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/80535721
Status will be re-evaluated on next push.
Please contact @peterschrammel, @thk123, or @allredj for support.
Common spurious failures:
- the cbmc commit has disappeared in the mean time (e.g. in a force-push)
- the author is not in the list of contributors (e.g. first-time contributors).
mmuesly
force-pushed
the
feature_expr2c_extension
branch
from
131bb8c to
1381399
Compare
There was a problem hiding this comment.
This PR failed Diffblue compatibility checks (cbmc commit: 1381399).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/80797564
Status will be re-evaluated on next push.
Please contact @peterschrammel, @thk123, or @allredj for support.
Common spurious failures:
- the cbmc commit has disappeared in the mean time (e.g. in a force-push)
- the author is not in the list of contributors (e.g. first-time contributors).
|
@thk123 Have you had a chance to take a look on this? I might provide some support in merging this with other PR into a joined version und your guidance, if that helps. I really would appreciate, if the output of expr2ct becomes compilable soon. |
|
Thanks, so I will close this PR in favor of #2704. |
I tried to convert an exprt to compilable c code, but encountered some problems as struct type definitions and padding struct members are contained in the output.
This changes add a new class, that is capable to remove them from the conversion output.
Changing the behavior of expr2ct with parameters doesn't seem an easily feasible approach.
Further, "TRUE" and "FALSE" are not understood by the c compiler in the default case. I suggest to replace them with some accepted replacement values.